ntml_wb, fix buffer type #12825
Closed
ntml_wb, fix buffer type #12825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
approved these changes
Jan 31, 2024
icing
referenced
this pull request
Jan 31, 2024
lib/curl_ntlm_wb.c
Outdated
| @@ -266,7 +266,7 @@ static CURLcode ntlm_wb_response(struct Curl_easy *data, struct ntlmdata *ntlm, | |||
| size_t len_in = strlen(input), len_out = 0; | |||
| struct dynbuf b; | |||
| char *ptr = NULL; | |||
| usigned char buf[1024] | |||
| unsigned char buf[1024] | |||
There was a problem hiding this comment.
missing semicolon at the end as well 😅
|
This mistake was not detected by CI because currently the configure script is broken and cannot enable NTLM_WB since the check requires a detected A fix for that configure mistake exists in #12479 but we have held off on merging that on purpose since NTLM_WB is scheduled to get removed in June 2024. |
bagder
reviewed
Jan 31, 2024
lib/curl_ntlm_wb.c
Outdated
| @@ -266,7 +266,7 @@ static CURLcode ntlm_wb_response(struct Curl_easy *data, struct ntlmdata *ntlm, | |||
| size_t len_in = strlen(input), len_out = 0; | |||
| struct dynbuf b; | |||
| char *ptr = NULL; | |||
| usigned char buf[1024] | |||
| unsigned char buf[1024] | |||
There was a problem hiding this comment.
Suggested change
| unsigned char buf[1024] | |
| unsigned char buf[1024]; |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to 8e9c304
Reported-by: tranzystorekk