krb5: ignore clang warnings on mvsnprintf() #12803
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Proposing this, to have the local printf wrapper verified for format issues: --- a/lib/krb5.c
+++ b/lib/krb5.c
@@ -434,6 +434,9 @@ static char level_to_char(int level)
/* Send an FTP command defined by |message| and the optional arguments. The
function returns the ftp_code. If an error occurs, -1 is returned. */
+static int ftp_send_command(struct Curl_easy *data, const char *message, ...)
+ CURL_PRINTF(2, 3);
+
static int ftp_send_command(struct Curl_easy *data, const char *message, ...)
{
int ftp_code;Follow-up to 0923012 |
bagder
force-pushed
the
bagder/krb-clang
branch
from
067cde0
to
f6fd307
Compare
|
Much better! |
"error: format string is not a string literal" Follow-up to 0923012 which made the warning appear Assisted-by: Viktor Szakats
bagder
force-pushed
the
bagder/krb-clang
branch
from
f6fd307
to
7301a11
Compare
|
Oops, I meant the |
|
I don't get any warnings with clang anymore after this! |
|
That's interesting. It seems the compiler is clever enough to apply this knowledge to the function itself. It also means that some of these warning suppressions added earlier (called out "looking shit" in a comment), may be redundant after all. |
|
Following-up on this: #12812 Turns out most of them became redundant after adding |
vszakats
added a commit
that referenced
this pull request
Jan 27, 2024
- delete redundant warning suppressions for `-Wformat-nonliteral`. This now relies on `CURL_PRINTF()` and it's theoratically possible that this macro isn't active but the warning is. We're ignoring this as a corner-case here. - replace two pragmas with code changes to avoid the warnings. Follow-up to aee4ebe #12803 Follow-up to 0923012 #12540 Follow-up to 3829759 #12489 Reviewed-by: Daniel Stenberg Closes #12812
1 task
vszakats
added a commit
that referenced
this pull request
Jan 28, 2024
- tool_msgs: delete redundant `-Wformat-nonliteral` suppression pragma. - whitespace formatting in `mprintf.h`, lib518, lib537. - lib518: fix wrong variable in `sizeof()`. - lib518: bump variables to `rlim_t`. Follow-up to e2b3941 #1469 - lib518: sync error message with lib537 Follow-up to 365322b - lib518, lib537: replace `-Wformat-nonliteral` suppression pragmas by reworking test code. Follow-up to 5b286c2 #12812 Follow-up to aee4ebe #12803 Follow-up to 0923012 #12540 Follow-up to 3829759 #12489 Reviewed-by: Daniel Stenberg Closes #12814
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"error: format string is not a string literal"