Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ftp+file, use stack buffer for resume handling #12789

Closed
wants to merge 5 commits into from

Conversation

icing
Copy link
Contributor

@icing icing commented Jan 25, 2024

instead of data->state.buffer

@icing icing changed the title file, use stack scratch buffer for resume handling ftp, use stack scratch buffer for resume handling Jan 25, 2024
@icing icing changed the title ftp, use stack scratch buffer for resume handling ftp+file, use stack buffer for resume handling Jan 25, 2024
@bagder
Copy link
Member

bagder commented Jan 25, 2024

file.c still uses the state.buffer for downloads in file_do, did you mean to leave that part out?

@icing
Copy link
Contributor Author

icing commented Jan 26, 2024

file.c still uses the state.buffer for downloads in file_do, did you mean to leave that part out?

Added now.

@bagder bagder closed this in a6c9a33 Jan 26, 2024
bagder added a commit that referenced this pull request Jan 26, 2024
This is malloc'ed memory and it does not more. Test 742 helps us verify
this.

Closes #12789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants