Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urlapi: remove assert #12775

Closed
wants to merge 1 commit into from
Closed

urlapi: remove assert #12775

wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Jan 24, 2024

This assert triggers wrongly when CURLU_GUESS_SCHEME and CURLU_NO_AUTHORITY are both set and the URL is a single path.

I think this assert has played out its role. It was introduced in a rather big refactor.

Follow-up to 4cfa5bc

Reported-by: promptfuzz_ on hackerone

@bagder
urlapi: remove assert
1bbdc67 
This assert triggers wrongly when CURLU_GUESS_SCHEME and
CURLU_NO_AUTHORITY are both set and the URL is a single path.

I think this assert has played out its role. It was introduced in a
rather big refactor.

Follow-up to 4cfa5bc

Reported-by: promptfuzz_ on hackerone
@bagder bagder closed this in 1621136 Jan 24, 2024
@bagder bagder deleted the bagder/urlapi-assert branch January 24, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tidy-up URL
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bagder