Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install curl.1 with cmake as well #12759

Closed
wants to merge 1 commit into from
Closed

Install curl.1 with cmake as well #12759

wants to merge 1 commit into from
+4 −1

Conversation

levitte
Copy link
Contributor

@levitte levitte commented Jan 22, 2024

Ref: #12730

@bagder bagder requested a review from vszakats January 23, 2024 07:29
@vszakats
Copy link
Member

LGTM, thanks @levitte!

@bagder
Copy link
Member

bagder commented Jan 23, 2024

@levitte do you think you can rebase this against master? I merged the curldown branch and now this has merge conflicts ...

@vszakats
Copy link
Member

When testing this locally, it applies fine to the latest master (e17b89d).

@bagder
Copy link
Member

bagder commented Jan 23, 2024

Thanks, so yes if I just get the patch and git am it, it works as-is! Good, I'll merge!

@bagder bagder closed this in fe290cb Jan 23, 2024
@bagder
Copy link
Member

bagder commented Jan 23, 2024

Thanks!

@levitte levitte deleted the install-curl.1-too branch January 24, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vszakats vszakats vszakats approved these changes

Assignees
No one assigned
Labels
build cmake cmdline tool
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@levitte @vszakats @bagder