Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CURLINFO_USED_PROXY: return a bool whether the proxy was used #12719

Closed
wants to merge 2 commits into from
Closed

CURLINFO_USED_PROXY: return a bool whether the proxy was used #12719

wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Jan 16, 2024 •
edited

Idea: #12669

  • - test case 536 verifies
  • - %{proxy_used} for -w

@bagder bagder added feature-window A merge of this requires an open feature window connecting & proxies libcurl API labels Jan 16, 2024
genotrance
genotrance reviewed Jan 23, 2024
View reviewed changes
include/curl/curl.h Outdated Show resolved Hide resolved
@bagder bagder marked this pull request as ready for review January 23, 2024 16:54
@github-actions github-actions bot added the tests label Feb 21, 2024
@bagder bagder changed the title CURLINFO_WAS_PROXY: return a bool whether the proxy was used CURLINFO_USED_PROXY: return a bool whether the proxy was used Feb 21, 2024
@bagder
CURLINFO_USED_PROXY: return bool whether the proxy was used
dcc6bf3 
Adds test536 to verify

Closes #12719
@bagder
write-out: add '%{proxy_used}'
13d77f5 
Returns 1 if the previous transfer used a proxy, otherwise 0. Useful to
for example determine if a `NOPROXY` pattern matched the hostname or
not.

Extended test 970 and 972
@bagder bagder closed this in cc04c73 Feb 22, 2024
@bagder bagder deleted the bagder/was-proxy branch February 22, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genotrance genotrance genotrance left review comments

Assignees
No one assigned
Labels
cmdline tool connecting & proxies feature-window A merge of this requires an open feature window libcurl API tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bagder @genotrance