version: show only the libpsl version, not its dependencies #12700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The libpsl version output otherwise also includes version number for its dependencies, like IDN lib, but since libcurl does not use libpsl's IDN functionality those components are not important. Ref: curl/curl-for-win#63
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Jan 15, 2024
- add manual build for libpsl. It's shorter than calling up autotools, which is broken in curl-for-win and also has an libpsl upstream issue on Windows. It's more fragile and may break by upstream changes. - retrofit curl patch for a clean libpsl version string: curl/curl@72bd88a curl/curl#12700 - exclude libpsl from `-zero` and `-bldtst` builds.
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Jan 15, 2024
- add manual build for libpsl. It's shorter than calling up autotools, which is broken in curl-for-win and also has an libpsl upstream issue on Windows. It's more fragile and may break by upstream changes. - retrofit curl patch for a clean libpsl version string: curl/curl@72bd88a curl/curl#12700 - exclude libpsl from `-zero` and `-bldtst` builds. Closes #63
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Jan 15, 2024
- add manual build for libpsl. It's shorter/quicker than calling up autotools. Autotools is broken in curl-for-win and also has an libpsl upstream issue on Windows. It also fixes symbol visibility to be hidden. But, it's also more fragile and upstream changes may break it. - retrofit curl patch for a clean libpsl version string: curl/curl@72bd88a curl/curl#12700 - exclude libpsl from `-zero` and `-bldtst` builds. Closes #63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libpsl version output otherwise also includes version number for its dependencies, like IDN lib, but since libcurl does not use libpsl's IDN functionality those components are not important.
Ref: curl/curl-for-win#63