Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User-Agent not suppressed by -A for proxy #12680

Closed
icing opened this issue Jan 10, 2024 · 0 comments
Closed

User-Agent not suppressed by -A for proxy #12680

icing opened this issue Jan 10, 2024 · 0 comments
Labels
connecting & proxies HTTP

Comments

@icing
Copy link
Contributor

icing commented Jan 10, 2024 •
edited

I did this

> nc -l 8000 & sleep 0.1 && curl -A '' -x http://localhost:8000 https://httpbin.org/get
CONNECT httpbin.org:443 HTTP/1.1
Host: httpbin.org:443
User-Agent:
Proxy-Connection: Keep-Alive

(well, actually @dfandrich did), while:

> nc -l 8000 & sleep 0.1 && curl --proxy-header 'User-Agent:' -x http://localhost:8000 https://httpbin.org/get
CONNECT httpbin.org:443 HTTP/1.1
Host: httpbin.org:443
Proxy-Connection: Keep-Alive

I expected the following

Not an empty User-Agent: with -A.

curl/libcurl version

curl 8.5.0

operating system

macOS/Linux/Windows happens on all of them
@dfandrich dfandrich changed the title User-Agent not supressed by -A for proxy User-Agent not suppressed by -A for proxy Jan 10, 2024
bagder added a commit that referenced this issue Jan 10, 2024
@bagder
http_proxy: a blank CURLOPT_USERAGENT should not be used in CONNECT
0bf37e5 
Extended test 80 to verify this.

Reported-by: Stefan Eissing
Fixes #12680
@bagder bagder mentioned this issue Jan 10, 2024
Closed
@bagder bagder closed this as completed in 693cd16 Jan 11, 2024
bagder added a commit that referenced this issue Jan 14, 2024
@bagder
cf-h1-proxy: no CURLOPT_USERAGENT in CONNECT with hyper
1d3991b 
Follow-up to 693cd16 which was incomplete

Ref #12680
@bagder bagder mentioned this issue Jan 14, 2024
Closed
bagder added a commit that referenced this issue Jan 14, 2024
@bagder
cf-h1-proxy: no CURLOPT_USERAGENT in CONNECT with hyper
e186ca6 
Follow-up to 693cd16 which was incomplete

Ref #12680
Closes #12697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
connecting & proxies HTTP
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

http_proxy: a blank CURLOPT_USERAGENT should not be used in CONNECT curl/curl
2 participants
@icing @bagder