Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows vcxproj files are missing #12564

Closed
iAroc opened this issue Dec 20, 2023 · 7 comments
Closed

Windows vcxproj files are missing #12564

iAroc opened this issue Dec 20, 2023 · 7 comments
Labels
build dist Windows Windows-specific

Comments

@iAroc
Copy link

iAroc commented Dec 20, 2023 •
edited

I did this

Heyya

I just tried to updated to curl stable 8.5.0, and saw that the libcurl.vcxproj files are missing.
they are also missing here on git:
https://github.com/curl/curl/tree/master/projects/Windows/VC14.30/lib

They where there until 8.4.0.

would be nice if those can be added back

I expected the following

curl/libcurl version

curl 8.5.0, git

operating system

Windows

Edit:
to clarify:
https://curl.se/download.html - download curl-8.5.0.zip from there, and the files are missing
https://curl.se/download/ - download curl-8.4.0.zip from here, and the files are there
@bagder
Copy link
Member

bagder commented Dec 20, 2023 

$ unzip -l curl-8.5.0.zip | grep sln
    18225  2023-12-05 15:57   curl-8.5.0/projects/Windows/VC14.20/src/curl.sln
    32140  2023-12-05 15:57   curl-8.5.0/projects/Windows/VC14.20/curl-all.sln
    18231  2023-12-05 15:57   curl-8.5.0/projects/Windows/VC14.20/lib/libcurl.sln
    18225  2023-11-17 15:45   curl-8.5.0/projects/Windows/VC14.10/src/curl.sln
    32140  2023-11-17 15:45   curl-8.5.0/projects/Windows/VC14.10/curl-all.sln
    18231  2023-11-17 15:45   curl-8.5.0/projects/Windows/VC14.10/lib/libcurl.sln
    18225  2023-12-05 15:57   curl-8.5.0/projects/Windows/VC14.30/src/curl.sln
    32140  2023-11-17 15:45   curl-8.5.0/projects/Windows/VC14.30/curl-all.sln
    18231  2023-11-17 15:45   curl-8.5.0/projects/Windows/VC14.30/lib/libcurl.sln
    18227  2021-08-23 00:23   curl-8.5.0/projects/Windows/VC14/src/curl.sln
    32142  2021-08-23 00:23   curl-8.5.0/projects/Windows/VC14/curl-all.sln
    18233  2021-08-23 00:23   curl-8.5.0/projects/Windows/VC14/lib/libcurl.sln
$ unzip -l curl-8.4.0.zip | grep sln
    18227  2022-02-13 11:21   curl-8.4.0/projects/Windows/VC10/src/curl.sln
    32142  2022-02-13 11:21   curl-8.4.0/projects/Windows/VC10/curl-all.sln
    18233  2022-02-13 11:21   curl-8.4.0/projects/Windows/VC10/lib/libcurl.sln
    18227  2021-08-23 00:23   curl-8.4.0/projects/Windows/VC12/src/curl.sln
    32142  2021-08-23 00:23   curl-8.4.0/projects/Windows/VC12/curl-all.sln
    18233  2021-08-23 00:23   curl-8.4.0/projects/Windows/VC12/lib/libcurl.sln
    18225  2023-10-05 09:58   curl-8.4.0/projects/Windows/VC14.10/src/curl.sln
    32140  2023-10-05 09:58   curl-8.4.0/projects/Windows/VC14.10/curl-all.sln
    18231  2023-10-05 09:58   curl-8.4.0/projects/Windows/VC14.10/lib/libcurl.sln
    18225  2023-10-05 09:58   curl-8.4.0/projects/Windows/VC14.30/src/curl.sln
    32140  2023-10-05 09:58   curl-8.4.0/projects/Windows/VC14.30/curl-all.sln
    18231  2023-10-05 09:58   curl-8.4.0/projects/Windows/VC14.30/lib/libcurl.sln
    18227  2022-02-13 11:21   curl-8.4.0/projects/Windows/VC11/src/curl.sln
    32142  2022-02-13 11:21   curl-8.4.0/projects/Windows/VC11/curl-all.sln
    18233  2022-02-13 11:21   curl-8.4.0/projects/Windows/VC11/lib/libcurl.sln
    18227  2021-08-23 00:23   curl-8.4.0/projects/Windows/VC14/src/curl.sln
    32142  2021-08-23 00:23   curl-8.4.0/projects/Windows/VC14/curl-all.sln
    18233  2021-08-23 00:23   curl-8.4.0/projects/Windows/VC14/lib/libcurl.sln

@iAroc
Copy link
Author

iAroc commented Dec 20, 2023 •
edited

its the .vcxproj files that are missing (the actual project) and not the .sln (project container)

if you open the curl-all.sln with visual studio, it throws you errors, telling you it cant load the project because the files are missing

@bagder
Copy link
Member

bagder commented Dec 20, 2023

They seem to also be missing in the daily snapshots

@bagder
Copy link
Member

bagder commented Dec 20, 2023

I've been told you can generate such files with cmake

@bagder bagder added build Windows Windows-specific dist labels Dec 20, 2023
@iAroc
Copy link
Author

iAroc commented Dec 20, 2023

its true that you can generate a complete sln with cmake, but you have to pre-select all the flags there already and then get one project, instead of one sln where you could set everything in the sln.

Anyway, in case you guys wanna go the route that windows users need to use cmake (which it totally fine) then the complete project-folder can be removed, since now its just misleading

@bagder
Copy link
Member

bagder commented Dec 20, 2023

I offered a work-around. This was not intended, as then we would have removed the entire directory...

bagder added a commit that referenced this issue Dec 20, 2023
@bagder
Makefile.am: fix the MSVC project generation
525834e 
It made the vcxproj files not get included in dist tarballs.

Regression since 74423b5 (8.5.0)

Reported-by: iAroc on github
Fixes #12564
@bagder bagder mentioned this issue Dec 20, 2023
Closed
@bagder bagder closed this as completed in 3cd153d Dec 21, 2023
@bagder
Copy link
Member

bagder commented Dec 21, 2023

This means that the daily snapshots starting tomorrow should have them again, in case you want to try a new set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build dist Windows Windows-specific
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Makefile.am: fix the MSVC project generation curl/curl
2 participants
@bagder @iAroc