Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Respect $TMPDIR when creating sockets #12545

Closed
wants to merge 1 commit into from
Closed

tests: Respect $TMPDIR when creating sockets #12545

wants to merge 1 commit into from

Conversation

yedayak
Copy link
Contributor

@yedayak yedayak commented Dec 17, 2023

When running on termux, where $TMPDIR isn't /tmp, running the tests failed, since the server config tried creating sockets in /tmp, without checking the temp dir config. Use the TMPDIR variable that makes it find the correct directory everywhere [0]

[0] https://perldoc.perl.org/File::Temp#tempfile

@yedayak
tests: Respect $TMPDIR when creating sockets
8f044a3 
When running on termux, where $TMPDIR isn't /tmp, running the tests
failed, since the server config tried creating sockets in /tmp, without
checking the temp dir config. Use the TMPDIR variable that makes it find
the correct directory everywhere [0]

[0] https://perldoc.perl.org/File::Temp#tempfile
@github-actions github-actions bot added the tests label Dec 17, 2023
@bagder
Copy link
Member

bagder commented Dec 18, 2023

Thanks!

@bagder bagder closed this in ad50d81 Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yedayak @bagder