Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows: delete redundant headers #12539

Closed
wants to merge 5 commits into from
Closed

windows: delete redundant headers #12539

wants to merge 5 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Dec 16, 2023 •
edited

winsock2.h pulls in windows.h. ws2tcpip.h pulls in winsock2.h.
winsock2.h and ws2tcpip.h are also pulled by curl/curl.h.

Keep only those headers that are not already included, or the code under
it uses something from that specific header.

Closes #12539

@github-actions github-actions bot added the tests label Dec 16, 2023
@vszakats vszakats mentioned this pull request Dec 16, 2023
Closed
4 tasks
@vszakats vszakats added Windows Windows-specific tidy-up and removed tidy-up labels Dec 18, 2023
@vszakats vszakats closed this in 03e7dff Dec 18, 2023
@vszakats vszakats deleted the winhdr branch December 18, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests Windows Windows-specific
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vszakats