build: remove redundant CURL_PULL_* settings
#12502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These macros were not propagated to the source code from CMake. autotools set only one of them (`CURL_PULL_SYS_POLL_H`), initially to address an AIX issue [1]. This later broke when introducing `system.h` [2] without the logic it enabled. A subsequent fix [3] re-added it the logic, and also enable it for AIX before its use, directly in `system.h`. [1] 2012-11-23: 665adcd [2] 2017-03-29: 9506d01 curl#1373 [3] 2017-08-25: 8a84fcc curl#1828 curl#1833 Closes #xxxxx
bagder
approved these changes
Dec 11, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These macros were not propagated to the source code from CMake.
autotools set only one of them (
CURL_PULL_SYS_POLL_H), initially toaddress an AIX issue [1]. This later broke when introducing
system.h[2] without the logic it enabled. A subsequent fix [3] re-added the
logic, and also enabled it for AIX before its use, directly in
system.h.[1] 2012-11-23: 665adcd
[2] 2017-03-29: 9506d01 #1373
[3] 2017-08-25: 8a84fcc #1828 #1833
Closes #12502