Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURLINFO_PRETRANSFER_TIME_T and CURLINFO_PRETRANSFER_TIME descriptions disagree #12431

Closed
eeverettrbx opened this issue Nov 30, 2023 · 1 comment

Comments

@eeverettrbx
Copy link

I did this

The man page for CURLINFO_PRETRANSFER_TIME says

It includes the sending of the protocol- specific protocol instructions that triggers a transfer.

but the man page for CURLINFO_PRETRANSFER_TIME_T says

It does not involve the sending of the protocol- specific request that triggers a transfer.

despite the fact that both are obtained from data->progress.t_pretransfer

I expected the following

It looks like the wording used to be the same until CURLINFO_PRETRANSFER_TIME's man page was updated in #6453 , presumably that one is correct and CURLINFO_PRETRANSFER_TIME_T's page just needs to be updated as well?

curl/libcurl version

curl 8.4.0

operating system

n/a

jay added a commit to jay/curl that referenced this issue Nov 30, 2023
- Change CURLINFO_PRETRANSFER_TIME_T explanation to say that it
  includes protocol-specific instructions that trigger a transfer.

Prior to this change it explicitly said that it did not include those
instructions but that is incorrect.

The change is a copy of the fixed explanation already in
CURLINFO_PRETRANSFER_TIME, fixed by ec8dcd7.

Reported-by: eeverettrbx@users.noreply.github.com

Fixes curl#12431
Closes #xxxx
jay added a commit to jay/curl that referenced this issue Nov 30, 2023
- Change CURLINFO_PRETRANSFER_TIME_T explanation to say that it
  includes protocol-specific instructions that trigger a transfer.

Prior to this change it explicitly said that it did not include those
instructions in the time, but that is incorrect.

The change is a copy of the fixed explanation already in
CURLINFO_PRETRANSFER_TIME, fixed by ec8dcd7.

Reported-by: eeverettrbx@users.noreply.github.com

Fixes curl#12431
Closes #xxxx
@jay jay closed this as completed in 8414273 Dec 1, 2023
@jay
Copy link
Member

jay commented Dec 1, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants