Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DoH trace configuration #12411

Closed
wants to merge 6 commits into from
Closed

DoH trace configuration #12411

wants to merge 6 commits into from

Conversation

icing
Copy link
Contributor

@icing icing commented Nov 27, 2023

  • refs [Suggestion] New option "-vv" for interoperation with "--doh-url" #12397 where it is dicussed how to en-/disable verbose output of DoH operations
  • introducing struct curl_trc_feat to track a curl feature for tracing
  • adding data->state.feat optionally pointing to the feature a transfer belongs to
  • adding trace functions and verbosity checks on features
  • using trace feature in DoH code
  • documenting doh as feature for --trace-config

@icing icing added feature-window A merge of this requires an open feature window and removed libcurl API labels Nov 27, 2023
@bagder
Copy link
Member

bagder commented Dec 18, 2023

@icing can you take a look at the merge conflict here?

@icing
Copy link
Contributor Author

icing commented Dec 18, 2023

@icing can you take a look at the merge conflict here?

@bagder rebased.

@bagder
Copy link
Member

bagder commented Jan 7, 2024

This is marked feature window and it is my fault we missed it this time. I still think this change is a good idea and will keep this for merge in the next window.

@icing
Copy link
Contributor Author

icing commented Feb 6, 2024

Rebased again after the curldown nuke.

- refs curl#12397 where it is dicussed how to en-/disable verbose output
  of DoH operations
- introducing `struct curl_trc_feat` to track a curl feature for
  tracing
- adding `data->state.feat` optionally pointing to the feature a
  transfer belongs to
- adding trace functions and verbosity checks on features
- using trace feature in DoH code
- documenting `doh` as feature for `--trace-config`
@bagder bagder closed this in f7e5987 Feb 20, 2024
@bagder
Copy link
Member

bagder commented Feb 20, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-window A merge of this requires an open feature window libcurl API
Development

Successfully merging this pull request may close these issues.

None yet

2 participants