Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: add CURL_DISABLE_BINDLOCAL option #12345

Closed
wants to merge 1 commit into from
Closed

cmake: add CURL_DISABLE_BINDLOCAL option #12345

wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Nov 16, 2023 •
edited

To match similar autotools option.

Default is ON.

Closes #12345

@vszakats
cmake: add CURL_DISABLE_BINDLOCAL option
cb3e3f8 
Default is `ON`.

Closes #xxxxx
bagder
bagder approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should extend test 1165 to also verify that the cmake build is in sync.

@vszakats vszakats closed this in 20bb363 Nov 17, 2023
@vszakats vszakats deleted the cmake-localbinding branch November 17, 2023 11:27
@vszakats vszakats mentioned this pull request Nov 17, 2023
Closed
vszakats added a commit that referenced this pull request Nov 20, 2023
@vszakats
cmake: add test for DISABLE options, add CURL_DISABLE_HEADERS_API
33493db 
- tests: verify CMake `DISABLE` options.

  Make an exception for 2 CMake-only ones, and one more that's
  using a different naming scheme, also in autotools and source.

- cmake: add support for `CURL_DISABLE_HEADERS_API`.

Suggested-by: Daniel Stenberg
Ref: #12345 (review)

Closes #12353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
build cmake
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vszakats @bagder