Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile.am: drop vc10, vc11 and vc12 from the dist tarball #12288

Closed
wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Nov 7, 2023

They are end of life products. Support for generating them remain in the repo for a while but this change drops them from distribution.

They are end of life products. Support for generating them remain in the
repo for a while but this change drops them from distribution.
@bagder bagder added build Windows Windows-specific dist labels Nov 7, 2023
@bagder bagder closed this in 3d93d18 Nov 7, 2023
@bagder bagder deleted the bagder/vc-eol-dist branch November 7, 2023 10:34
@MarcelRaad
Copy link
Member

These old versions were actually the only use case I still saw for the project files at all as CMake removed support for generating them for VC 10 and 11, and deprecated VC 12. Newer Visual Studio versions even come with CMake.

@bagder
Copy link
Member Author

bagder commented Nov 7, 2023

No one would be happier than me if we would remove them all from both git and the dist, but are our users ready for that?

@jay
Copy link
Member

jay commented Nov 8, 2023

I'm still using the vc10 and vc12 projects on some older computers. I switch between builds a lot and SSL libraries using the configuration drop down. I can re-generate if necessary but a lot of the time it isn't necessary. Like for example if no file is added I usually don't have to regenerate. If I want to switch between OpenSSL and WinSSL (Schannel) I don't have to regenerate. If I want to switch between 64/32 or release/debug I don't have to regenerate. And so on. I just choose from the drop down. The project configurations are very basic and had to I write a script to enable http2. As for users that may be using the old versions I don't know if that's happening. I see no reason to disable generating them for distribution if they're going to remain in the repo. I guess we'll find out if anyone makes a report about it.

@bagder
Copy link
Member Author

bagder commented Nov 8, 2023

I can re-generate if necessary but a lot of the time it isn't necessary.

I would imagine that most curl developers need that rather than to have them shipped in the tarball as we do change the source file set every once in a while.

I see no reason to disable generating them for distribution if they're going to remain in the repo.

It's a gradual thing. Let's first see if anyone even notices this step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build dist Windows Windows-specific
Development

Successfully merging this pull request may close these issues.

None yet

3 participants