Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows VC14.20 project missing #12282

Closed
wants to merge 2 commits into from
Closed

Windows VC14.20 project missing #12282

wants to merge 2 commits into from

Conversation

dsv123
Copy link
Contributor

@dsv123 dsv123 commented Nov 6, 2023 •
edited

Windows projects included VC14, VC14.10, VC14.30 but not VC14.20.
OpenSSL and WolfSSL bat scripts mention VC14.20 so I don't suspect an underlying problem with this platform toolset.

Updated the templates to produce a VC14.20 project. Project opens (and builds) in Visual Studio 2019 as expected.
The VC14.30 solution contained text "Visual Studio 15" instead of "Visual Studio 17", updated.

@dsv123
Windows VC14.20 project missing
7eef45a 
Windows projects included VC14, VC14.10, VC14.30 but not VC14.20.
OpenSSL and Wolf SSL scripts mention VC14.20 so I don't see a reason why this is missing.
Updated the templates to produce a VC14.20 project.
Project opens in Visual Studio 2019 as expected.
@vszakats vszakats added build Windows Windows-specific labels Nov 6, 2023
@bagder
Copy link
Member

bagder commented Nov 6, 2023

Since Visual Studio 2012 and older all seem to be end of life now, I think we can drop them from the release archives. Based on this: https://learn.microsoft.com/en-us/visualstudio/releases/2019/servicing-vs2019

@dsv123
Update libcurl.tmpl
4a450db 
II hadn't saved this file after updating it on previous pull request.
This file was identical to that from VC14.30 Fixed version numbers.
@bagder bagder closed this in 2828709 Nov 7, 2023
@bagder
Copy link
Member

bagder commented Nov 7, 2023

Thanks!

@bagder bagder reopened this Nov 7, 2023
@bagder
Copy link
Member

bagder commented Nov 7, 2023

@dsv123 this does not add any code to Makefile.am in the style of 14_30 so I'm pretty sure this then does not create working 14.20 files in the tarballs. See:

curl/Makefile.am

Lines 600 to 622 in 2828709

echo "generating '$(VC14_30_LIBVCXPROJ)'"; \
awk -v proj_type=vcxproj \
-v lib_srcs="$$sorted_lib_srcs" \
-v lib_hdrs="$$sorted_lib_hdrs" \
-v lib_rc="$$win32_lib_rc" \
-v lib_vauth_srcs="$$sorted_lib_vauth_srcs" \
-v lib_vauth_hdrs="$$sorted_lib_vauth_hdrs" \
-v lib_vquic_srcs="$$sorted_lib_vquic_srcs" \
-v lib_vquic_hdrs="$$sorted_lib_vquic_hdrs" \
-v lib_vssh_srcs="$$sorted_lib_vssh_srcs" \
-v lib_vssh_hdrs="$$sorted_lib_vssh_hdrs" \
-v lib_vtls_srcs="$$sorted_lib_vtls_srcs" \
-v lib_vtls_hdrs="$$sorted_lib_vtls_hdrs" \
"$$awk_code" $(srcdir)/$(VC14_30_LIBTMPL) > $(VC14_30_LIBVCXPROJ) || { exit 1; }; \
\
echo "generating '$(VC14_30_SRCVCXPROJ)'"; \
awk -v proj_type=vcxproj \
-v src_srcs="$$sorted_src_srcs" \
-v src_hdrs="$$sorted_src_hdrs" \
-v src_rc="$$win32_src_rc" \
-v src_x_srcs="$$sorted_src_x_srcs" \
-v src_x_hdrs="$$sorted_src_x_hdrs" \
"$$awk_code" $(srcdir)/$(VC14_30_SRCTMPL) > $(VC14_30_SRCVCXPROJ) || { exit 1; };)

@bagder
Copy link
Member

bagder commented Nov 7, 2023

I realized this when I made #12288 just now

@bagder
Copy link
Member

bagder commented Nov 7, 2023

Anyway, that should be fixed in a separate PR, just wanted to highlight this.

@bagder bagder closed this Nov 7, 2023
bagder added a commit that referenced this pull request Nov 7, 2023
@bagder
Makefile: generate the VC 14.20 project files at dist-time
2c106d8 
Follow-up to 2828709 (#12282)
@bagder bagder mentioned this pull request Nov 7, 2023
Closed
bagder added a commit that referenced this pull request Nov 7, 2023
@bagder
Makefile: generate the VC 14.20 project files at dist-time
d08dac3 
Follow-up to 2828709 (#12282)
bagder added a commit that referenced this pull request Nov 11, 2023
@bagder
Makefile: generate the VC 14.20 project files at dist-time
74423b5 
Follow-up to 2828709 (#12282)

Closes #12290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
build Windows Windows-specific
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dsv123 @bagder @vszakats