curl.h: add CURLE_TOO_LARGE #12269
Closed
curl.h: add CURLE_TOO_LARGE #12269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would CURLE_BAD_FUNCTION_ARGUMENT work instead? Or is that too oblique?
|
I think that error code should be used when there is a more direct and immediate correlation between an input the result. |
bagder
force-pushed
the
bagder/CURLE_TOO_LARGE
branch
from
c282072
to
fdffc78
Compare
|
hyper ci job test 1154 is returning CURLE_OUT_OF_MEMORY instead of CURLE_TOO_LARGE |
bagder
force-pushed
the
bagder/CURLE_TOO_LARGE
branch
from
973dd45
to
b07b07d
Compare
bagder
force-pushed
the
bagder/CURLE_TOO_LARGE
branch
from
75bb943
to
4a42a1e
Compare
bagder
added
needs-votes
bagder
force-pushed
the
bagder/CURLE_TOO_LARGE
branch
from
4a42a1e
to
fac5c61
Compare
bagder
force-pushed
the
bagder/CURLE_TOO_LARGE
branch
from
fac5c61
to
ef39a7d
Compare
bagder
force-pushed
the
bagder/CURLE_TOO_LARGE
branch
from
ef39a7d
to
26888e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new error code that can be used when an internal field grows too large, like when a dynbuf reaches its maximum. Previously it would return CURLE_OUT_OF_MEMORY for this, which is highly misleading.
Ref: #12268