Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile.mk: drop Windows support #12224

Closed
wants to merge 6 commits into from
Closed

Makefile.mk: drop Windows support #12224

wants to merge 6 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Oct 28, 2023 •
edited

And DLL-support with it. This leaves Makefile.mk for MS-DOS and Amiga.

We recommend CMake instead. With unity mode it's much faster, and about
the same without.

Ref: #12221 (comment)
Closes #12224

  • Hold off till curl v8.6.0.

@vszakats vszakats added build feature-window A merge of this requires an open feature window Windows Windows-specific labels Oct 28, 2023
@github-actions github-actions bot added CI Continuous Integration cmdline tool labels Oct 28, 2023
@jay
Copy link
Member

jay commented Oct 29, 2023

@gvanem does this affect how you build curl?

@gvanem
Copy link
Contributor

gvanem commented Oct 29, 2023

@jay No and I have no objections to remove support for these.

@vszakats vszakats mentioned this pull request Nov 17, 2023
Closed
@vszakats vszakats closed this in ba8752e Dec 16, 2023
@vszakats vszakats deleted the mk-drop-windows-support branch December 16, 2023 13:18
@firstrose
Copy link

Excuse me, but could you tell me how to build curl by mingw with cmake under windows now? Start from 8.6.0, the makefile doesn't work anymore. It confuses me before I see this. Thanks.

@jay
Copy link
Member

jay commented Mar 31, 2024 •
edited

Excuse me, but could you tell me how to build curl by mingw with cmake under windows now? Start from 8.6.0, the makefile doesn't work anymore. It confuses me before I see this. Thanks.

Original mingw is no longer supported. It may still work I haven't tried. mingw-w64 is supported. To have cmake generate mingw build files use -G "MinGW Makefiles", for example

git clone https://github.com/curl/curl.git
mkdir curlbuild
cd curlbuild
cmake ../curl -G "MinGW Makefiles" -DCURL_USE_SCHANNEL=ON
cmake --build .

you will of course need the prerequisites for mingw gcc and make installed beforehand which should be as simple as open a MSYS2 MINGW64 shell prompt and pacman -S mingw-w64-x86_64-toolchain

also you can set the path where cmake will install curl with -DCMAKE_INSTALL_PREFIX:PATH=yourpathhere

see also INSTALL-CMAKE.md for cmake info

jay added a commit to jay/curl that referenced this pull request Mar 31, 2024
@jay
INSTALL-CMAKE.md: explain cmake -G <generator-name>
7dcfcec 
- Explain that CMake's -G option can be used to specify which build
  system to generate files for.

Example: cmake ../curl -G "MinGW Makefiles"

Ref: curl#12224 (comment)

Closes #xxxx
jay added a commit to jay/curl that referenced this pull request Mar 31, 2024
@jay
INSTALL-CMAKE.md: explain cmake -G <generator-name>
8b2d74d 
- Explain that CMake's -G option can be used to specify which build
  system to generate files for.

Example: cmake ../curl -G "MinGW Makefiles"

Ref: curl#12224 (comment)

Closes #xxxx
jay added a commit to jay/curl that referenced this pull request Mar 31, 2024
@jay
INSTALL-CMAKE.md: explain cmake -G <generator-name>
a29f9fe 
- Explain that CMake's -G option can be used to specify which build
  system to generate files for.

Example: cmake ../curl -G "MinGW Makefiles"

Ref: curl#12224 (comment)

Closes #xxxx
jay added a commit to jay/curl that referenced this pull request Mar 31, 2024
@jay
INSTALL-CMAKE.md: explain cmake -G <generator-name>
d0a6531 
- Explain that CMake's -G option can be used to specify which build
  system to generate files for.

Example: cmake ../curl -G "MinGW Makefiles"

Ref: curl#12224 (comment)

Closes #xxxx
@jay jay mentioned this pull request Mar 31, 2024
Closed
jay added a commit that referenced this pull request Apr 1, 2024
@jay
INSTALL-CMAKE.md: explain cmake -G <generator-name>
d36c1a7 
- Explain that CMake's -G option can be used to specify which build
  system to generate files for.

Example: cmake ../curl -G "MinGW Makefiles"

Ref: #12224 (comment)

Closes #13244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
build CI Continuous Integration cmdline tool feature-window A merge of this requires an open feature window Windows Windows-specific
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vszakats @jay @gvanem @firstrose @bagder