New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
curl_setup: disallow Windows IPv6 builds missing getaddrinfo #12221
Conversation
- On Windows if IPv6 is enabled but getaddrinfo is missing then #error the build. curl can be built with IPv6 support (ENABLE_IPV6) but without the ability to resolve hosts to IPv6 addresses (HAVE_GETADDRINFO). On Windows this is highly unlikely and should be considered a bad build configuration. Such a bad configuration has already given us a bug that was hard to diagnose. See curl#12134 and curl#12136 for discussion. Ref: curl#12134 Ref: curl#12136 Closes #xxxx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, both IPv6 and getaddrinfo
were added in Windows XP. Makes sense to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sensible lesson to draw from this past week
Related, we might also consider:
|
After this patch we assume availability of `getaddrinfo` and `freeaddrinfo`, first introduced in Windows XP. TODO: assume these also in autotools. Ref: curl#12221 (comment) Closes #xxxxx
After this patch we assume availability of `getaddrinfo` and `freeaddrinfo`, first introduced in Windows XP. TODO: assume these also in autotools. Ref: curl#12221 (comment) Closes #xxxxx
After this patch we assume availability of `getaddrinfo` and `freeaddrinfo`, first introduced in Windows XP. Meaning curl now requires building for Windows XP as a minimum. TODO: assume these also in autotools. Ref: #12221 (comment) Closes #12225
And DLL-support with it. This leaves `Makefile.mk` for MS-DOS and Amiga. We recommend CMake instead. With unity mode it's much faster, and about the same without. Ref: #12221 (comment) Reviewed-by: Daniel Stenberg Closes #12224
curl can be built with IPv6 support (ENABLE_IPV6) but without the ability to resolve hosts to IPv6 addresses (HAVE_GETADDRINFO). On Windows this is highly unlikely and should be considered a bad build configuration.
Such a bad configuration has already given us a bug that was hard to diagnose. See #12134 and #12136 for discussion.
Ref: #12134
Ref: #12136
Closes #xxxx