Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide call to tell connection to forget about a socket #12207

Closed
wants to merge 2 commits into from
Closed

Provide call to tell connection to forget about a socket #12207

wants to merge 2 commits into from

Conversation

icing
Copy link
Contributor

@icing icing commented Oct 26, 2023

  • fixed libssh.c workaround for a socket being closed by the library
  • eliminate the terrible hack in cf-socket.c to guess when this happened and try not closing the socket again.
  • fixes race in eyeballing when socket could have failed to be closed for a discarded connect attempt

@icing
Provide call to tell connection to forget about a socket
84edd8d 
- fixed libssh.c workaround for a socket being closed by
  the library
- eliminate the terrible hack in cf-socket.c to guess when
  this happened and try not closing the socket again.
- fixes race in eyeballing when socket could have failed to
  be closed for a discarded connect attempt
@bagder bagder closed this in 37b5cf4 Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder left review comments

Assignees
No one assigned
Labels
hacktoberfest-accepted
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icing @bagder