Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move async resolver state from easy handle to connectdata #12198

Closed
wants to merge 1 commit into from
Closed

Move async resolver state from easy handle to connectdata #12198

wants to merge 1 commit into from

Conversation

icing
Copy link
Contributor

@icing icing commented Oct 25, 2023

  • resolving is done for a connection, not for every transfer
  • save create/dup/free of a cares channel for each transfer
  • check values of setopt calls against a local channel if no connection has been attached yet, when needed.

@icing
Move async resolver state from easy handle to connectdata
6c1e124 
- resolving is done for a connection, not for every transfer
- save create/dup/free of a cares channel for each transfer
- check values of setopt calls against a local channel if no
  connection has been attached yet, when needed.
@icing icing added the tidy-up label Oct 25, 2023
@icing icing requested a review from bagder October 26, 2023 08:23
@bagder bagder closed this in 56a4db2 Oct 26, 2023
@bagder
Copy link
Member

bagder commented Oct 27, 2023

Unfortunately this introduced a torture test fail. On my machine this crashes:

$ ./runtests.pl -t41 -n 534

@bagder
Copy link
Member

bagder commented Oct 27, 2023

in a c-ares build I should add

@bagder
Copy link
Member

bagder commented Oct 27, 2023

Follow-up in #12219

@bagder bagder mentioned this pull request Dec 14, 2023
Closed
bagder added a commit that referenced this pull request Dec 14, 2023
@bagder
Revert "urldata: move async resolver state from easy handle to connec…
d0ca04a 
…tdata"

This reverts commit 56a4db2 (#12198)

We want the c-ares channel to be held in the easy handle, not per
connection - for performance.
@bagder bagder mentioned this pull request Dec 14, 2023
Closed
bagder added a commit that referenced this pull request Dec 14, 2023
@bagder
Revert "urldata: move async resolver state from easy handle to connec…
54f89e8 
…tdata"

This reverts commit 56a4db2 (#12198)

We want the c-ares channel to be held in the easy handle, not per
connection - for performance.
bagder added a commit that referenced this pull request Dec 15, 2023
@bagder
Revert "urldata: move async resolver state from easy handle to connec…
907eea0 
…tdata"

This reverts commit 56a4db2 (#12198)

We want the c-ares channel to be held in the easy handle, not per
connection - for performance.

Closes #12524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted tidy-up
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icing @bagder