Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (Open)LDAP connection reuse #12166

Closed
wants to merge 2 commits into from
Closed

fix (Open)LDAP connection reuse #12166

wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Oct 20, 2023

No description provided.

... to make sure it has the current 'data' pointer and not a stale old
one.

Reported-by: Dan Fandrich
Fixes a minor memory leak on LDAP connection reuse.

Doing the allocation already in *setup_connection() is wrong since that
connect struct might get discarded early when an existing connection is
reused instead.
@bagder bagder added the LDAP label Oct 20, 2023
@bagder bagder requested a review from dfandrich October 20, 2023 14:09
@bagder bagder closed this in 3afbe06 Oct 21, 2023
bagder added a commit that referenced this pull request Oct 21, 2023
Fixes a minor memory leak on LDAP connection reuse.

Doing the allocation already in *setup_connection() is wrong since that
connect struct might get discarded early when an existing connection is
reused instead.

Closes #12166
@bagder bagder deleted the bagder/ldap-reuse branch October 21, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant