cmake: USE_QUICHE uses openssl_check_symbol_exists #12160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the CheckQuicSupportInOpenSSL function was removed from USE_NGTCP2 in dfe2e6d, but the USE_QUICHE section wasn't updated accordingly. this results in cmake errors when USE_QUICHE is enabled: -- Found QUICHE: /path/to/quiche/target/release/libquiche.a CMake Error at CMakeLists.txt:712 (CheckQuicSupportInOpenSSL): Unknown CMake command "CheckQuicSupportInOpenSSL". Signed-off-by: Casey Bodley <cbodley@redhat.com>
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Oct 19, 2023
Regression from dee310d #curl#11555 Reported-by: Casey Bodley Fixes curl#12160 Closes #xxxxx
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Oct 19, 2023
An orphan call to `CheckQuicSupportInOpenSSL()` remained after a recent update when checking QUIC for quiche. Restore this function and fixup the callers to use it. Regression from dee310d #curl#11555 Reported-by: Casey Bodley Fixes curl#12160 Closes #xxxxx
|
Ops, did not notice this is a PR, not a report, sorry. My patch is a little different, by avoiding redundancy in the quic-checking logic and also allowing to pair quiche with wolfSSL. Also points to the mainline commit I made this mistake in dee310d. |
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Oct 19, 2023
An orphan call to `CheckQuicSupportInOpenSSL()` remained after a recent update when checking QUIC for quiche. Restore this function and fixup the callers to use it. Regression from dee310d #curl#11555 Reported-by: Casey Bodley <cbodley@redhat.com> Fixes curl#12160 Closes curl#12162
|
thanks, closing in favor of #12162 |
vszakats
added a commit
that referenced
this pull request
Oct 22, 2023
An orphan call to `CheckQuicSupportInOpenSSL()` remained after a recent update when checking QUIC for quiche. Move back QUIC detection to a function and fixup callers to use that. Also make sure that quiche gets QUIC from BoringSSL, because it doesn't support other forks at this time. Regression from dee310d #11555 Reported-by: Casey Bodley <cbodley@redhat.com> Fixes #12160 Closes #12162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
CheckQuicSupportInOpenSSLfunction was removed fromUSE_NGTCP2in dee310d, but theUSE_QUICHEsection wasn't updated accordingly. this results in cmake errors whenUSE_QUICHEis enabled: