Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better buffer size checks for socks4a user and hostname #12139

Closed
wants to merge 2 commits into from
Closed

better buffer size checks for socks4a user and hostname #12139

wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Oct 16, 2023

No description provided.

@bagder
socks: better buffer size checks for socks4a user and hostname
bba3205 
Also limit the proxy user name to 255 bytes, which is the same limit as
in SOCKS5.

Reported-by: sd0 on hackerone
@bagder
test729: verify socks4a with excessive proxy user name length
744cafd
@github-actions github-actions bot added the tests label Oct 16, 2023
@bagder bagder closed this in 01057d6 Oct 16, 2023
@bagder bagder deleted the bagder/socks4a branch October 16, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
connecting & proxies hacktoberfest-accepted tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bagder