Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8.4.0 fails to build with CURL_DISABLE_VERBOSE_STRINGS=ON #12083

Closed
SChernykh opened this issue Oct 11, 2023 · 8 comments
Closed

8.4.0 fails to build with CURL_DISABLE_VERBOSE_STRINGS=ON #12083

SChernykh opened this issue Oct 11, 2023 · 8 comments
Labels
build

Comments

@SChernykh
Copy link

SChernykh commented Oct 11, 2023 •
edited

I did this

The cmake command line I used to generate Visual Studio solution file:

cmake .. -G "Visual Studio 16 2019" -DCURL_TARGET_WINDOWS_VERSION=0x0600 -DBUILD_CURL_EXE=OFF -DBUILD_SHARED_LIBS=OFF -DCURL_ZLIB=OFF -DCURL_DISABLE_ALTSVC=ON -DCURL_DISABLE_COOKIES=ON -DCURL_DISABLE_DOH=ON -DCURL_DISABLE_GETOPTIONS=ON -DCURL_DISABLE_HSTS=ON -DCURL_DISABLE_LIBCURL_OPTION=ON -DCURL_DISABLE_MIME=ON -DCURL_DISABLE_NETRC=ON -DCURL_DISABLE_NTLM=ON -DCURL_DISABLE_PARSEDATE=ON -DCURL_DISABLE_PROGRESS_METER=ON -DCURL_DISABLE_SHUFFLE_DNS=ON -DCURL_DISABLE_SOCKETPAIR=ON -DCURL_DISABLE_VERBOSE_STRINGS=ON -DHTTP_ONLY=ON -DCURL_ENABLE_SSL=OFF -DUSE_LIBIDN2=OFF -DCURL_USE_LIBPSL=OFF -DCURL_USE_LIBSSH2=OFF -DENABLE_UNIX_SOCKETS=OFF

It generated a solution file without issues, but then it failed to compile with this error:

curl_trc.c(247,1): error C2059: syntax error: 'do'`

Removing Curl_trc_cf_infof definition in curl_trc.c fixed the build for me.

I expected the following

curl should build without errors when CURL_DISABLE_VERBOSE_STRINGS=ON

curl/libcurl version

curl 8.4.0

operating system

Windows
@vszakats vszakats added the build label Oct 11, 2023
@pedro0311
Copy link

Did you try to add to "-DCMAKE_C_FLAGS" -> -std=gnu99 ?

@SChernykh
Copy link
Author

Did you try to add to "-DCMAKE_C_FLAGS" -> -std=gnu99 ?

I still get the same error with this flag.

@jay
Copy link
Member

jay commented Oct 12, 2023

@vszakats is this a duplicate of #11880

@SChernykh
Copy link
Author

This is exactly the same as #11891 but I got it with Visual Studio on Windows.

@vszakats
Copy link
Member

@jay I think so.

@jay
Copy link
Member

jay commented Oct 12, 2023

@vszakats would you mind creating a PR with your fix so we can see if it works? #11880 seems to have gone stale. maybe @SChernykh can test?

@vszakats
Copy link
Member

@jay: I will do that in the coming days/week, unless someone beats me to it.

@vszakats vszakats mentioned this issue Oct 13, 2023
Closed
7 tasks
@vszakats
Copy link
Member

PR #12105 is ready for testing. We're appreciating feedback.

@bagder bagder mentioned this issue Oct 26, 2023
Closed
@bagder bagder closed this as completed in dac293c Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

trace: replace variadic macros with C89 syntax vszakats/curl
4 participants
@jay @vszakats @SChernykh @pedro0311