Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

h3: add support for ngtcp2 with AWS-LC builds #12066

Closed
wants to merge 2 commits into from
Closed

h3: add support for ngtcp2 with AWS-LC builds #12066

wants to merge 2 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Oct 8, 2023 •
edited 

curl 8.4.0-DEV (x86_64-apple-darwin) libcurl/8.4.0-DEV (SecureTransport) AWS-LC/1.15.0 nghttp2/1.56.0 ngtcp2/0.19.1 nghttp3/0.15.0
Release-Date: [unreleased]
Protocols: dict file ftp ftps gopher gophers http https imap imaps ldap ldaps mqtt pop3 pop3s rtsp smb smbs smtp smtps telnet tftp ws wss
Features: alt-svc AsynchDNS HSTS HTTP2 HTTP3 HTTPS-proxy IPv6 Largefile MultiSSL NTLM SSL threadsafe UnixSockets

Also delete an obsolete GnuTLS TODO and update the header comment in
FindNGTCP2.cmake.

Closes #12066

@vszakats
h3: add support for ngtcp2 with AWS-LC builds
8c2d5c0 
Also delete an obsolete GnuTLS TODO comment and update the header in
`FindNGTCP2.cmake`.

Closes #xxxxx
@vszakats vszakats added cmake HTTP/3 h3 or quic related labels Oct 8, 2023
@vszakats vszakats mentioned this pull request Oct 8, 2023
Closed
vszakats added a commit that referenced this pull request Oct 8, 2023
@vszakats
build: do not publish HAVE_BORINGSSL, HAVE_AWSLC macros
58a95b6 
Syncing this up with CMake.

Source code uses the built-in `OPENSSL_IS_AWSLC` and
`OPENSSL_IS_BORINSSL` macros to detect BoringSSL and AWS-LC. No help is
necessary from the build tools.

The one use of `HAVE_BORINGSSL` in the source turned out to be no longer
necessary for warning-free BoringSSL + Schannel builds. Ref: #1610 #2634

autotools detects this anyway for display purposes.
CMake detects this to decide whether to use the BoringSSL-specific
crypto lib with ngtcp2. It detects AWS-LC, but doesn't use the detection
result just yet (planned in #12066).

Ref: #11964

Reviewed-by: Daniel Stenberg
Reviewed-by: Jay Satiro
Closes #12065
@vszakats vszakats closed this in 0e4bef0 Oct 8, 2023
@vszakats vszakats deleted the cmake-awslc-ngtcp2-h3 branch October 8, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
cmake HTTP/3 h3 or quic related
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vszakats @bagder