You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The difference is that pop3_state_starttls_resp() in pop3.c:789 behaves differently depending on the pp.cache_size. With small recv(), cache_size is 0, where on "normal" test runs, additional response data is in the cache.
Since CURLUSESSL_TRY is active, test982 proceeds with user authentication where in "normal" run, it does not.
curl/libcurl version
curl 8.4.0-DEV
operating system
macOS
The text was updated successfully, but these errors were encountered:
I believe the test case is broken. It looks like it assumes that the full sequence is read and handled by curl in a single read, which of course it should not.
Maybe also reject some available data from the stream in libcurl? The tls handshake is always initiated by the client so it should be safe, although useless for normal operations. It may still fail the test however if the data is not yet present (delayed) when the rejection check occurs.
Currently, if pipelined data is not read, it is taken as tls handshake data and then makes the latter failing, which is what we want (although it would have another error code if tls is required).
But there's no support for upgrade to tls in the test server, so I had to use --ssl instead of --ssl-reqd as a workaround.
This test checks pipelining is rejected, but in the target case, curl does not even see it as such and data is processed by the TLS handshake, thus the test is meaningless. The real problem for testing is we can't force curl to read this garbage before the tls handshake.
We surely have the same problem with tests 980, 981 and 983.
The ideal solution would probably to have the buffered data fed into the tls handshake (to "unshuffle" stream data) and the cache check removed: tests for this could then be deleted.
I did this
I expected the following
The test to succeed.
The difference is that
pop3_state_starttls_resp()
inpop3.c:789
behaves differently depending on thepp.cache_size
. With small recv(),cache_size
is 0, where on "normal" test runs, additional response data is in the cache.Since
CURLUSESSL_TRY
is active, test982 proceeds with user authentication where in "normal" run, it does not.curl/libcurl version
curl 8.4.0-DEV
operating system
macOS
The text was updated successfully, but these errors were encountered: