Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: validate CURL_DEFAULT_SSL_BACKEND config value #11998

Closed

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Sep 30, 2023

Before this patch CMake builds accepted any value and it was used at
runtime as-is. This patch make sure that the selected default backend
is also enabled in the build. It also enforces a full lowercase value.

This improves reproducibility and brings CMake in sync with autotools
which already worked like described above.

Follow-up to 26c7feb #11774

Closes #11998

Before this patch CMake builds accepted any value and it was used at
runtime as-is. This patch make sure that the selected default backend
is also enabled in the build. It also enforces a full lowercase value.
This improves reproducibility.

This brings CMake closer to autotools which already worked like
described above.

Follow-up to 26c7feb curl#11774

Closes #xxxxx
@github-actions github-actions bot added the build label Sep 30, 2023
@vszakats vszakats closed this in 717c15f Sep 30, 2023
@vszakats vszakats deleted the def-ssl-backend-value-more-reproducible branch September 30, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant