Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: fix HAVE_WRITABLE_ARGV detection #11978

Closed
wants to merge 2 commits into from
Closed

cmake: fix HAVE_WRITABLE_ARGV detection #11978

wants to merge 2 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Sep 28, 2023 •
edited

Move detection before the creation of detection results in
curl_config.h.

Ref: #11964 (effort to sync cmake detections with autotools)

Closes #11978

@vszakats
cmake: fix HAVE_WRITABLE_ARGV detection
220e49a 
Move detection before the creation of detection results
in `curl_config.h`.

Ref: curl#11964

Closes #xxxxx
@vszakats vszakats added the cmake label Sep 28, 2023
@github-actions github-actions bot added the build label Sep 28, 2023
@vszakats vszakats mentioned this pull request Sep 28, 2023
Closed
16 tasks
@jay
Copy link
Member

jay commented Sep 29, 2023 •
edited

I suggest add a sentence why you're making the change, for example

Move detection before the creation of detection results
in `curl_config.h`.

This change is part of the effort to sync cmake and autotools output.

Ref: #11964

Closes #xxxxx

@vszakats vszakats closed this in ca7daad Sep 29, 2023
@vszakats vszakats deleted the fix-HAVE_WRITABLE_ARGV branch September 29, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build cmake
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vszakats @jay