Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: add feature checks for memrchr and getifaddrs #11954

Closed
wants to merge 5 commits into from
Closed

cmake: add feature checks for memrchr and getifaddrs #11954

wants to merge 5 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Sep 26, 2023 •
edited

  • HAVE_MEMRCHR for memrchr.
  • HAVE_GETIFADDRS for getifaddrs.
    This was present in lib/curl_config.h.cmake but the
    detection logic was missing.

To match existing autotools feature checks.

TODO: Must rebase once we merged #11951.

Closes #11954

@vszakats
cmake: move global stdlib.h use to specific detections
03c6259 
Based on autotools logic in `m4/curl-functions.m4`.
@vszakats
cmake: stop using stddef.h for detections
75127da 
Based on autotools logic in `m4/curl-functions.m4`,
`stddef.h` isn't necessary for any detection.
@vszakats
cmake: move global string.h use to specific detections
64d29cf 
Based on autotools logic in `m4/curl-functions.m4`.
@vszakats
cmake: fix to detect HAVE_GETIFADDRS
361a346
@vszakats
cmake: detect memrchr like autotools
7a001f2
@vszakats vszakats added the cmake label Sep 26, 2023
@vszakats vszakats closed this in 1411c5e Sep 26, 2023
@vszakats vszakats deleted the cmake-add-missing-checks branch September 26, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cmake
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vszakats