connect: only start the happy eyeballs timer when needed #11939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timeout is only used when there is a second address family, for the delayed eyeballer.
This was referenced Sep 25, 2023
|
Thanks! |
ehuss
added a commit
to ecnelises/curl-rust
that referenced
this pull request
Oct 11, 2023
This test is hanging on Linux with the 8.4.0 update. My poor understanding is that `perform()` should not be used with `curl_multi_socket_action` (that is, it should only use `perform` or `action`, not both). Removing this seems to fix things. Note that there were some other hang-related changes in the 8.4.0 release. I bisected the hang to curl/curl#11939, which then uncovered some curl tests that were hanging in curl/curl#12033. That then spawned off two more changes to fix the hangs (both of which are also in 8.4.0). However, this upload_lots was still failing. I think this is likely due to an incorrect use of the API poorly interacting with the timer changes in 8.4.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeout is only used when there is a second address family, for the delayed eyeballer.