Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: fix stderr initialization in unity builds #11929

Closed
wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Sep 25, 2023

Before this patch, in certain build configurations the curl tool may
not have displayed anything (debug, macOS), or crashed at startup
(debug, Windows).

Follow-up to 3f8fc25
Necessary after 2f17a9b

Closes #11929

@vszakats
Copy link
Member Author

vszakats commented Sep 25, 2023

This patch initially aimed to fix this CI error, which I attributed to a failing curl tool:
could not get curl version! at C:/projects/curl/tests/runtests.pl line 2439.

But it turns out this is unrelated, and also happens without unity:
https://ci.appveyor.com/project/curlorg/curl/builds/48113479
(these are test CI jobs to trigger the issue by building and trying to run tests.)

@dfandrich
Copy link
Contributor

dfandrich commented Sep 25, 2023 via email

@vszakats
Copy link
Member Author

The binaries are working when downloaded locally, and there are no 3rd party DLLs required. This makes me think that the problem may be as simple as curl.exe not finding libcurl.dll. But I failed to come up with a DLL copy command that made it work, probably due to trivial mistake I'm making in appveyor.yml.

@vszakats vszakats closed this in 06133d3 Sep 25, 2023
@vszakats vszakats deleted the fix-unity-stderr branch September 25, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants