Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: fix unity symbol collisions in h2 builds #11912

Closed
wants to merge 1 commit into from
Closed

cmake: fix unity symbol collisions in h2 builds #11912

wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Sep 21, 2023 •
edited

Regression from 331b89a

Closes #11912

@vszakats vszakats added the cmake label Sep 21, 2023
@vszakats vszakats closed this in 48ba5d9 Sep 22, 2023
@vszakats vszakats deleted the unity-refix branch September 22, 2023 09:19
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
@vszakats @ptitSeb
cmake: fix unity symbol collisions in h2 builds
360b4e9 
Regression from 331b89a

Reviewed-by: Daniel Stenberg
Reviewed-by: Jay Satiro
Closes curl#11912
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

@jay jay jay approved these changes

Assignees
No one assigned
Labels
cmake connecting & proxies HTTP HTTP/2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vszakats @bagder @jay