Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wolfSSL/OpenSSL inconsistencies #11886

Closed
wants to merge 2 commits into from
Closed

wolfSSL/OpenSSL inconsistencies #11886

wants to merge 2 commits into from

Conversation

michael-o
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the TLS label Sep 19, 2023
@michael-o michael-o mentioned this pull request Sep 19, 2023
Closed
@bagder
Copy link
Member

bagder commented Sep 20, 2023

The only inconsistency seems to that it should still accept the ssl_capath even the cainfo blob option is set? I think the commit message could explain this.

@michael-o
wolfssl: overwrite CURLOPT_CAINFO with CURLOPT_CAINFO_BLOB consistent…
dffbf1f 
… with the OpenSSL provider

While CAfile is nulled as documented with CURLOPT_CAINFO_BLOB,
CApath remains intact.
@michael-o michael-o force-pushed the wolfssf-openssl-inconsistencies branch from a305f51 to dffbf1f Compare September 20, 2023 06:59
@michael-o
Copy link
Contributor Author

The only inconsistency seems to that it should still accept the ssl_capath even the cainfo blob option is set? I think the commit message could explain this.

Agree, thought the same yesterday. Changed.

@bagder
Copy link
Member

bagder commented Sep 20, 2023

Thanks!

@bagder bagder closed this in cc123e2 Sep 20, 2023
bagder pushed a commit that referenced this pull request Sep 20, 2023
@michael-o @bagder
wolfssl: allow capath with CURLOPT_CAINFO_BLOB
4521823 
Remain consistent with OpenSSL. While CAfile is nulled as documented
with CURLOPT_CAINFO_BLOB, CApath remains intact.

Closes #11886
@michael-o michael-o deleted the wolfssf-openssl-inconsistencies branch September 20, 2023 11:54
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
@michael-o @ptitSeb
wolfssl: use ssl_cafile/ssl_capath variables consistent with openssl.c
28a78d5 
Closes curl#11886
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
@michael-o @ptitSeb
wolfssl: allow capath with CURLOPT_CAINFO_BLOB
fc604a5 
Remain consistent with OpenSSL. While CAfile is nulled as documented
with CURLOPT_CAINFO_BLOB, CApath remains intact.

Closes curl#11886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
TLS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michael-o @bagder