Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cookie cleanups #11862

Closed
wants to merge 3 commits into from
Closed

cookie cleanups #11862

wants to merge 3 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Sep 15, 2023

  • reduce variable scope, add const
  • do not store the expire or max-age strings in memory
  • remove unnecessary struct fields filename and version
  • reduce the hash table size

@bagder
cookie: remove unnecesary struct fields
4696db3 
Plus: reduce the hash table size from 256 to 63. It seems unlikely to
make much of a speed difference for most use cases but saves 1.5KB of
data per instance.
@bagder
cookie: do not store the expire or max-age strings
c94da83 
Convert it to an expire time at once and save memory.
@bagder
cookie: reduce variable scope, add const
2aad261
@bagder bagder closed this in 6127567 Sep 15, 2023
bagder added a commit that referenced this pull request Sep 15, 2023
@bagder
cookie: do not store the expire or max-age strings
8c285a7 
Convert it to an expire time at once and save memory.

Closes #11862
@bagder bagder deleted the bagder/cookie-struct-cleanup branch September 15, 2023 20:10
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
@bagder @ptitSeb
cookie: remove unnecessary struct fields
97e2de7 
Plus: reduce the hash table size from 256 to 63. It seems unlikely to
make much of a speed difference for most use cases but saves 1.5KB of
data per instance.

Closes curl#11862
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
@bagder @ptitSeb
cookie: do not store the expire or max-age strings
ec9ae09 
Convert it to an expire time at once and save memory.

Closes curl#11862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cookies tidy-up
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bagder