Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http3: SNI should not be set if host is literal IP address #11827

Closed
vvb2060 opened this issue Sep 10, 2023 · 1 comment
Closed

http3: SNI should not be set if host is literal IP address #11827

vvb2060 opened this issue Sep 10, 2023 · 1 comment
Labels
HTTP/3 h3 or quic related TLS

Comments

@vvb2060
Copy link
Contributor

vvb2060 commented Sep 10, 2023

I did this

curl --http3-only https://1.1.1.1/cdn-cgi/trace

I expected the following

sni=off

curl/libcurl version

curl 8.2.1 (x86_64-w64-mingw32) libcurl/8.2.1 OpenSSL/3.1.2 (Schannel) zlib/1.3 brotli/1.1.0 zstd/1.5.5 WinIDN libssh2/1.11.0 nghttp2/1.56.0 ngtcp2/0.19.1 nghttp3/0.15.0

operating system

windows
@vvb2060
Copy link
Contributor Author

vvb2060 commented Sep 10, 2023

image

https://www.rfc-editor.org/rfc/rfc6066#section-3

Literal IPv4 and IPv6 addresses are not permitted in "HostName".

@vvb2060 vvb2060 mentioned this issue Sep 10, 2023
Closed
@bagder bagder added TLS HTTP/3 h3 or quic related labels Sep 10, 2023
jay pushed a commit to vvb2060/curl that referenced this issue Sep 10, 2023
@vvb2060 @jay
quic: don't set SNI if hostname is an IP address
c3f00e2 
- If hostname is an IP address don't set it as the SNI.

The RFC says: Literal IPv4 and IPv6 addresses are not permitted in
"HostName".

We already check this for non-QUIC connections.

Ref: https://www.rfc-editor.org/rfc/rfc6066#section-3

Fixes curl#11827
Closes curl#11828
jay pushed a commit to vvb2060/curl that referenced this issue Sep 10, 2023
@vvb2060 @jay
quic: don't set SNI if hostname is an IP address
29c216d 
The RFC says: Literal IPv4 and IPv6 addresses are not permitted in
"HostName".

We already do this for non-QUIC connections.

Ref: https://www.rfc-editor.org/rfc/rfc6066#section-3

Fixes curl#11827
Closes curl#11828
jay pushed a commit to vvb2060/curl that referenced this issue Sep 11, 2023
@vvb2060 @jay
quic: don't set SNI if hostname is an IP address
b070f33 
RFC 6066 says: Literal IPv4 and IPv6 addresses are not permitted in
"HostName".

We already do this for non-QUIC connections.

Ref: https://www.rfc-editor.org/rfc/rfc6066#section-3

Fixes curl#11827
Closes curl#11828
@jay jay closed this as completed in d5c562c Sep 11, 2023
ptitSeb pushed a commit to wasix-org/curl that referenced this issue Sep 25, 2023
@vvb2060 @ptitSeb
quic: don't set SNI if hostname is an IP address
84cbafe 
We already do this for TLS connections.

RFC 6066 says: Literal IPv4 and IPv6 addresses are not permitted in
"HostName".

Ref: https://www.rfc-editor.org/rfc/rfc6066#section-3

Fixes curl#11827
Closes curl#11828
@brbzull0 brbzull0 mentioned this issue Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
HTTP/3 h3 or quic related TLS
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ngtcp2: SNI should not be set if host is literal IP address vvb2060/curl
2 participants
@bagder @vvb2060