Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: fix HAVE_TIME_T_UNSIGNED check #11825

Conversation

benoit-pierre
Copy link
Contributor

The syntax was incorrect (need a proper main body), and the test condition was wrong (resulting in a signed time_t detected as unsigned).

The syntax was incorrect (need a proper main body), and the test
condition was wrong (resulting in a signed `time_t` detected as
unsigned).
@bagder
Copy link
Member

bagder commented Sep 10, 2023

It is curious why it would fail in that direction for you. For me it failed and detects it as not unsigned...

@bagder bagder closed this in 3e39cda Sep 10, 2023
@bagder
Copy link
Member

bagder commented Sep 10, 2023

Thanks!

@benoit-pierre
Copy link
Contributor Author

What I meant is there were 2 errors: a syntax error, preventing the check of ever detecting an unsigned time_t, and an error in the test condition (t > 0), incorrectly flipping the result on my machine once the syntax issue was solved.

@benoit-pierre benoit-pierre deleted the pr/fix_time_t_is_unsigned_check branch September 10, 2023 10:35
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
The syntax was incorrect (need a proper main body), and the test
condition was wrong (resulting in a signed `time_t` detected as
unsigned).

Closes curl#11825
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants