Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include.d: explain headers not printed prior 7.75.0 #11822

Closed
wants to merge 2 commits into from
Closed

include.d: explain headers not printed prior 7.75.0 #11822

wants to merge 2 commits into from

Conversation

pszlazak
Copy link
Contributor

@pszlazak pszlazak commented Sep 8, 2023

Prior to 7.75.0 response headers were not printed if -f/--fail was used and an error was reported by server.

This is NOK example for curl 7.74.0:

$ curl -q "http://httpbin.org/status/500" --include --fail
curl: (22) The requested URL returned error: 500 INTERNAL SERVER ERROR

This is OK example for curl 8.1.2:

$ curl -q "http://httpbin.org/status/500" --include --fail
HTTP/1.1 500 INTERNAL SERVER ERROR
Server: gunicorn/19.9.0
Date: Fri, 08 Sep 2023 15:15:43 GMT
Connection: keep-alive
Content-Type: text/html; charset=utf-8
Access-Control-Allow-Origin: *
Access-Control-Allow-Credentials: true
Content-Length: 0

curl: (22) The requested URL returned error: 500

This behavior was fixed in ab525c0 (precedes 7.75.0).

pszlazak added a commit to pszlazak/curl that referenced this pull request Sep 8, 2023
@pszlazak
include.d: explain headers not printed prior 7.75.0
0e403e5 
Prior to 7.75.0 response headers were not printed
if -f/--fail was used and an error was reported by
server.
This was fixed in ab525c0 (precedes 7.75.0).

Closes curl#11822
bagder
bagder reviewed Sep 8, 2023
View reviewed changes
docs/cmdline-opts/include.d Outdated Show resolved Hide resolved
pszlazak and others added 2 commits September 8, 2023 23:15
@pszlazak
include.d: explain headers not printed prior 7.75.0
fc57b5f 
Prior to 7.75.0 response headers were not printed
if -f/--fail was used and an error was reported by
server.
This was fixed in ab525c0 (precedes 7.75.0).

Closes curl#11822
@pszlazak @bagder
Applying changes suggested by reviewer
f0dd14e 
Co-authored-by: Daniel Stenberg <daniel@haxx.se>
@pszlazak pszlazak marked this pull request as ready for review September 9, 2023 20:58
@bagder
Copy link
Member

bagder commented Sep 9, 2023

Thanks!

@bagder bagder closed this in ba30c5e Sep 9, 2023
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
@pszlazak @ptitSeb
include.d: explain headers not printed with --fail before 7.75.0
ff98d20 
Prior to 7.75.0 response headers were not printed if -f/--fail was used
and an error was reported by server.  This was fixed in ab525c0
(precedes 7.75.0).

Closes curl#11822
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder left review comments

Assignees
No one assigned
Labels
cmdline tool documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pszlazak @bagder