Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: add support for CURL_DEFAULT_SSL_BACKEND #11774

Closed
wants to merge 1 commit into from
Closed

cmake: add support for CURL_DEFAULT_SSL_BACKEND #11774

wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Aug 31, 2023 •
edited

Allow overriding the default TLS backend via a CMake setting.

E.g.:
cmake [...] -DCURL_DEFAULT_SSL_BACKEND=mbedtls

Accepted values: bearssl, gnutls, mbedtls, openssl, rustls,
schannel, secure-transport, wolfssl

The passed string is baked into the curl/libcurl binaries.
The value is case-insensitive.

We added a similar option to autotools in 2017 via
c7170e2.

TODO: Convert to lowercase to improve reproducibility.

Closes #11774

@vszakats
cmake: add support for CURL_DEFAULT_SSL_BACKEND
4d45a94 
Allow overriding the default TLS backend via a CMake setting.

E.g.:
`cmake [...] -DCURL_DEFAULT_SSL_BACKEND=mbedtls`

Accepted values: bearssl, gnutls, mbedtls, openssl, rustls,
schannel, secure-transport, wolfssl

The string is baked into the final binary as a string. The
value is case-insensitive.

We added a similar option to autotools in 2017 via
c7170e2.

Closes #xxxxx
vszakats added a commit to curl/curl-for-win that referenced this pull request Aug 31, 2023
@vszakats
test cmake tls default option
9866536 
Ref: curl/curl#11774
vszakats added a commit to curl/curl-for-win that referenced this pull request Aug 31, 2023
@vszakats
test cmake tls default option (temp) [TESTED OK]
c74fe66 
Ref: curl/curl#11774
vszakats added a commit to curl/curl-for-win that referenced this pull request Aug 31, 2023
@vszakats
test cmake tls default option (temp) [TESTED OK]
ad7828b 
Ref: curl/curl#11774
@vszakats vszakats closed this in 26c7feb Aug 31, 2023
@vszakats vszakats deleted the cmake-default-tls-backend branch August 31, 2023 23:06
vszakats added a commit to curl/curl-for-win that referenced this pull request Aug 31, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
f70f8c5 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
curl/curl#11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 1, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
9a24ee7 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
curl/curl#11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 1, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
afba15d 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
curl/curl#11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 1, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
c1ef849 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
curl/curl#11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 1, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
72953b4 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
curl/curl#11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 1, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
274d6fc 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
curl/curl#11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 1, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
c2f96af 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
curl/curl#11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 1, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
40ffb1e 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
curl/curl#11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 1, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
5e5c375 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
curl/curl#11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 1, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
3add9ed 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
curl/curl#11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 2, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
ef698f7 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
curl/curl#11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 2, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
1bec8ee 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
curl/curl#11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 2, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
3d26289 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
curl/curl#11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 2, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
44a71dc 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
curl/curl#11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 2, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
68b57e5 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
curl/curl#11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 2, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
b23ea27 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
curl/curl#11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 2, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
373d97c 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
curl/curl#11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 3, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
81ab263 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
curl/curl#11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 3, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
f481e71 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 3, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
0511dd5 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 3, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
6f9ab09 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 3, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
fdc67d0 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 6, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
cc267df 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 7, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
b78cb5e 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 7, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
8583057 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 7, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
4093424 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 7, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
be33b15 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 20, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
297a842 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 20, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
cedd3ef 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 22, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
f41c48b 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 22, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
325cad4 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 22, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
73c7b2e 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 23, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
4189859 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 23, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
377c6da 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 24, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
544eeb5 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
@vszakats @ptitSeb
cmake: add support for CURL_DEFAULT_SSL_BACKEND
e8aba60 
Allow overriding the default TLS backend via a CMake setting.

E.g.:
`cmake [...] -DCURL_DEFAULT_SSL_BACKEND=mbedtls`

Accepted values: bearssl, gnutls, mbedtls, openssl, rustls,
schannel, secure-transport, wolfssl

The passed string is baked into the curl/libcurl binaries.
The value is case-insensitive.

We added a similar option to autotools in 2017 via
c7170e2.

TODO: Convert to lowercase to improve reproducibility.

Closes curl#11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 27, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
fe35e38 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 28, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
454b38b 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 28, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
0d2883b 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Sep 28, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
def6113 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl that referenced this pull request Sep 30, 2023
@vszakats
cmake: validate CURL_DEFAULT_SSL_BACKEND config value
09dae51 
Before this patch CMake builds accepted any value and it was used at
runtime as-is. This patch make sure that the selected default backend
is also enabled in the build. It also enforces a full lowercase value.
This improves reproducibility.

This brings CMake closer to autotools which already worked like
described above.

Follow-up to 26c7feb curl#11774

Closes #xxxxx
@vszakats vszakats mentioned this pull request Sep 30, 2023
Closed
vszakats added a commit that referenced this pull request Sep 30, 2023
@vszakats
cmake: validate CURL_DEFAULT_SSL_BACKEND config value
717c15f 
Before this patch CMake builds accepted any value and it was used at
runtime as-is. This patch make sure that the selected default backend
is also enabled in the build. It also enforces a full lowercase value.

This improves reproducibility and brings CMake in sync with autotools
which already worked like described above.

Follow-up to 26c7feb #11774

Closes #11998
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Oct 2, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
97b1def 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Oct 2, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
11d6776 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Oct 3, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
375a104 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Oct 5, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
baf9ecf 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Oct 7, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
fd15374 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Oct 7, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
9e22d98 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to vszakats/curl-for-win that referenced this pull request Oct 7, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
46c7f49 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
https://github dot com/curl/curl/pull/11774
vszakats added a commit to curl/curl-for-win that referenced this pull request Oct 8, 2023
@vszakats
curl: make SecureTransport the secondary TLS-backend
fba3391 
The 8.3.0-specific logic depends on this:
curl/curl@26c7feb
curl/curl#11774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cmake TLS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vszakats