Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sectransp: fix compiler warnings #11773

Closed
wants to merge 1 commit into from
Closed

sectransp: fix compiler warnings #11773

wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Aug 31, 2023 •
edited

https://github.com/curl/curl-for-win/actions/runs/6037489221/job/16381860220#step:3:11046

./curl-for-win/curl/lib/vtls/sectransp.c:2435:14: warning: unused variable 'success' [-Wunused-variable]
    OSStatus success;
             ^
./curl-for-win/curl/lib/vtls/sectransp.c:3300:44: warning: unused parameter 'sha256len' [-Wunused-parameter]
                                    size_t sha256len)
                                           ^

Closes #11773

@vszakats
sectransp: fix compiler warnings
9f01213 
https://github.com/curl/curl-for-win/actions/runs/6037489221/job/16381860220#step:3:11046
```
/Users/runner/work/curl-for-win/curl-for-win/curl/lib/vtls/sectransp.c:2435:14: warning: unused variable 'success' [-Wunused-variable]
    OSStatus success;
             ^
/Users/runner/work/curl-for-win/curl-for-win/curl/lib/vtls/sectransp.c:3300:44: warning: unused parameter 'sha256len' [-Wunused-parameter]
                                    size_t sha256len)
                                           ^
```

Closes #xxxxx
@vszakats vszakats added build appleOS specific to an Apple operating system labels Aug 31, 2023
@github-actions github-actions bot added the TLS label Aug 31, 2023
@vszakats
Copy link
Member Author

vszakats commented Aug 31, 2023 •
edited

There is also this one:

./curl-for-win/curl/lib/vtls/sectransp.c:1206:7: warning: 'CFURLCreateDataAndPropertiesFromResource' is deprecated:
  first deprecated in macOS 10.9 - For resource data, use the CFReadStream API.
  For file resource properties, use CFURLCopyResourcePropertiesForKeys.
  [-Wdeprecated-declarations]

vszakats added a commit to curl/curl-for-win that referenced this pull request Aug 31, 2023
@vszakats
curl: add patch to silence warnings (temp)
bc9a9af 
Ref: curl/curl#11773
vszakats added a commit to curl/curl-for-win that referenced this pull request Aug 31, 2023
@vszakats
curl: add patch to silence warnings (temp) [TESTED OK]
4b8ec8d 
Ref: curl/curl#11773
vszakats added a commit to curl/curl-for-win that referenced this pull request Aug 31, 2023
@vszakats
curl: add patch to silence warnings (temp) [TESTED OK]
5304794 
Ref: curl/curl#11773
@nickzman
Copy link
Member

LGTM.

@vszakats vszakats closed this in 4727d32 Aug 31, 2023
@vszakats vszakats deleted the macwarn branch August 31, 2023 23:06
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
@vszakats @ptitSeb
sectransp: fix compiler warnings
b44c87c 
https://github.com/curl/curl-for-win/actions/runs/6037489221/job/16381860220#step:3:11046
```
/Users/runner/work/curl-for-win/curl-for-win/curl/lib/vtls/sectransp.c:2435:14: warning: unused variable 'success' [-Wunused-variable]
    OSStatus success;
             ^
/Users/runner/work/curl-for-win/curl-for-win/curl/lib/vtls/sectransp.c:3300:44: warning: unused parameter 'sha256len' [-Wunused-parameter]
                                    size_t sha256len)
                                           ^
```

Closes curl#11773
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
appleOS specific to an Apple operating system build TLS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vszakats @nickzman