Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib539.c: use curl_free() to free libcurl allocated data #11746

Closed
wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Aug 28, 2023

Reported-by: Nicholas Nethercote

@github-actions github-actions bot added the tests label Aug 28, 2023
@bagder
Copy link
Member Author

bagder commented Aug 28, 2023

These mistakes are not detected or a problem as long as memdebug.h is included, as that provides the debug wrappers for all memory functions in the same style libcurl internals do it, which makes curl_free and free effectively the same call.

@jay
Copy link
Member

jay commented Aug 28, 2023

this needs a url to the report if there is one

@bagder
Copy link
Member Author

bagder commented Aug 28, 2023

this needs a url to the report if there is one

There is none. This is based on an IRC conversation.

@bagder bagder closed this in a06de2b Aug 28, 2023
@bagder bagder deleted the bagder/test539 branch August 28, 2023 11:25
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
In several test programs. These mistakes are not detected or a problem
as long as memdebug.h is included, as that provides the debug wrappers
for all memory functions in the same style libcurl internals do it,
which makes curl_free and free effectively the same call.

Reported-by: Nicholas Nethercote
Closes curl#11746
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants