Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tool_paramhlp: improve str2num() by avoiding unnecessary call to strlen() #11742

Closed
wants to merge 1 commit into from
Closed

tool_paramhlp: improve str2num() by avoiding unnecessary call to strlen() #11742

wants to merge 1 commit into from

Conversation

foutaise
Copy link
Contributor

After reading @bagder last blog entry regarding CVE-2020-19909, I had a look to str2num() function and realized that a small improvement might be applied to avoid an unnecessary call to strlen().

bagder
bagder approved these changes Aug 27, 2023
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bagder
Copy link
Member

bagder commented Aug 27, 2023

Thanks!

@bagder bagder closed this in 458c70d Aug 27, 2023
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
@foutaise @ptitSeb
tool_paramhlp: improve str2num(): avoid unnecessary call to strlen()
1f77d12 
Closes curl#11742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
cmdline tool
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@foutaise @bagder