Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl: switch to modern init for LibreSSL 2.7.0+ #11611

Closed
wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Aug 7, 2023

LibreSSL 2.7.0 (2018-03-21) introduced automatic initialization, OPENSSL_init_ssl() function and deprecated the old, manual init method, as seen in OpenSSL 1.1.0. Switch to the modern method when available.

Ref: https://ftp.openbsd.org/pub/OpenBSD/LibreSSL/libressl-2.7.0-relnotes.txt

Closes #11611

LibreSSL 2.7.0 (2018-03-21) introduced automatic initialization,
`OPENSSL_init_ssl()` function and deprecated the old, manual init
method, as seen in OpenSSL 1.1.0. Switch to the modern method when
available.

Ref: https://ftp.openbsd.org/pub/OpenBSD/LibreSSL/libressl-2.7.0-relnotes.txt

Closes #xxxxx
@vszakats
Copy link
Member Author

vszakats commented Aug 7, 2023

Looking to do the same in ossl_cleanup(), where the situation is murkier:

https://man.openbsd.org/OpenBSD-6.3/EVP_cleanup.3 - deprecated
https://man.openbsd.org/OpenBSD-6.3/ENGINE_cleanup.3 - not loading engines, so seems unnecessary
https://man.openbsd.org/OpenBSD-6.3/ERR_free_strings.3 - available, not a no-op
https://man.openbsd.org/OpenBSD-6.3/ERR_remove_thread_state.3 - available, not a no-op
https://man.openbsd.org/OpenBSD-6.3/ERR_remove_state.3 - deprecated
https://man.openbsd.org/OpenBSD-6.3/CONF_modules_free.3 - not loading CONF modules, so seems unnecessary
SSL_COMP_free_compression_methods - doesn't exist in LibreSSL

@vszakats vszakats closed this in bec0c5b Aug 7, 2023
@vszakats vszakats deleted the libressl-init-fix branch August 7, 2023 23:57
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
LibreSSL 2.7.0 (2018-03-21) introduced automatic initialization,
`OPENSSL_init_ssl()` function and deprecated the old, manual init
method, as seen in OpenSSL 1.1.0. Switch to the modern method when
available.

Ref: https://ftp.openbsd.org/pub/OpenBSD/LibreSSL/libressl-2.7.0-relnotes.txt

Reviewed-by: Daniel Stenberg
Closes curl#11611
vszakats added a commit to vszakats/curl that referenced this pull request Dec 15, 2023
Earlier we bumped LibreSSL to use modern initialization, but did not
touch deinitialization due to uncertainties [1]. Fix it in this patch.

Regression from bec0c5b curl#11611

[1] curl#11611 (comment)

Reported-by: Mike Hommey
Fixes curl#12525
Closes #xxxxx
vszakats added a commit to vszakats/curl that referenced this pull request Dec 15, 2023
Earlier we bumped LibreSSL to use modern initialization, but did not
touch deinitialization [1]. Fix it in this patch.

Regression from bec0c5b curl#11611

[1] curl#11611 (comment)

Reported-by: Mike Hommey
Fixes curl#12525
Closes curl#12526
vszakats added a commit that referenced this pull request Dec 15, 2023
Earlier we switched to use modern initialization with LibreSSL v2.7.0
and up, but did not touch deinitialization [1]. Fix it in this patch.

Regression from bec0c5b #11611

[1] #11611 (comment)

Reported-by: Mike Hommey
Reviewed-by: Daniel Stenberg
Fixes #12525
Closes #12526
@jay jay mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants