Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP/3, ngtcp2, shorten handshake, trace cleanup #11609

Closed
wants to merge 1 commit into from
Closed

HTTP/3, ngtcp2, shorten handshake, trace cleanup #11609

wants to merge 1 commit into from

Conversation

icing
Copy link
Contributor

@icing icing commented Aug 7, 2023 •
edited

  • shorten handshake timing by delayed x509 store load (OpenSSL) as we do for HTTP/2
  • cleanup of trace output, align with HTTP/2 output

Sample handshake times on my machine

> python3 tests/http/scorecard.py -H h3

BEFORE
Handshakes               ipv4                      ipv6
  Host                   Connect    Handshake      Connect    Handshake
  curl.se                   0 ms        53 ms         0 ms       219 ms

AFTER
Handshakes               ipv4                      ipv6
  Host                   Connect    Handshake      Connect    Handshake
  curl.se                   0 ms        29 ms         0 ms       196 ms

update: my ipv6 unborked itself, now seeing 22ms/22ms on both ip version...shrugs

@icing
HTTP/3, ngtcp2, shorten handshake, trace cleanup
b822843 
- shorten handshake timing by delayed x509 store load (OpenSSL)
  as we do for HTTP/2
- cleanup of trace output, align with HTTP/2 output
@github-actions github-actions bot added the tests label Aug 7, 2023
@bagder bagder added performance HTTP/3 h3 or quic related labels Aug 7, 2023
@bagder
Copy link
Member

bagder commented Aug 7, 2023

From my dev machine to curl.se, this PR reduces my handshake times from 18ms/18ms to 5ms/5ms...

@bagder bagder closed this in 199fb4b Aug 7, 2023
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
@icing @ptitSeb
http3/ngtcp2: shorten handshake, trace cleanup
1b64c6c 
- shorten handshake timing by delayed x509 store load (OpenSSL)
  as we do for HTTP/2
- cleanup of trace output, align with HTTP/2 output

Closes curl#11609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
HTTP/3 h3 or quic related performance tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icing @bagder