return error when receiving too large headers #11582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did some live tests with my Firefox and Chrome on Linux. Sending an endless stream of headers, when do they give up?
Neither of them seems to have a fixed limit as repeated runs show different results. Based on this, I think I should up the curl limit to 300KB. |
To avoid abuse. The limit is set to 300 KB. Incomplete research suggests that Chrome uses a 256-300 KB limit, while Firefox allows up to 1MB. Closes #11582
hyper has its own limit, I don't know what
bagder
force-pushed
the
bagder/headers-maxsize
branch
from
cfd8392
to
882535c
Compare
|
hyper has (rather annoyingly) its own limit which also returns a generic error which makes it very hard for us to catch specifically making us forced to return a rather bad error code there. Also, I don't know what the hyper limit is but I have asked: hyperium/hyper#3283 |
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
To avoid abuse. The limit is set to 300 KB for the accumulated size of all received HTTP headers for a single response. Incomplete research suggests that Chrome uses a 256-300 KB limit, while Firefox allows up to 1MB. Closes curl#11582
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid abuse. The limit is set to [updated] 300 KB.
Test 497 verifies.