Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtls: don't use OpenSSL's ERR_PACK. #1157

Closed
wants to merge 1 commit into from
Closed

vtls: don't use OpenSSL's ERR_PACK. #1157

wants to merge 1 commit into from

Conversation

agl
Copy link
Contributor

@agl agl commented Dec 7, 2016

ERR_PACK is an internal detail of OpenSSL. Also, when using it, a
function name must be specified which is overly specific: the test will
break whenever OpenSSL internally change things so that a different
function creates the error.

@agl
vtls: don't use OpenSSL's ERR_PACK.
b2e16d4 
ERR_PACK is an internal detail of OpenSSL. Also, when using it, a
function name must be specified which is overly specific: the test will
break whenever OpenSSL internally change things so that a different
function creates the error.
@mention-bot
Copy link

@agl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rousskov, @bagder and @ghedo to be potential reviewers.

@bagder bagder closed this in 71a5553 Dec 7, 2016
@bagder
Copy link
Member

bagder commented Dec 7, 2016

thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@agl @mention-bot @bagder