cmake: detect SSL_set0_wbio in OpenSSL
#11555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Present in OpenSSL 1.1.0 and BoringSSL. Missing from LibreSSL 3.8.0. Follow-up to f39472e While I'm here also fix `RAND_egd()` detection which was broken, likely all along. Closes curl#11555
vszakats
force-pushed
the
cmake-detect-ssl-set0-wbio
branch
from
18726a1
to
1abfa5a
Compare
vszakats
force-pushed
the
cmake-detect-ssl-set0-wbio
branch
from
96ffe0e
to
47a3b11
Compare
vszakats
changed the title
SSL_set0_wbioSSL_set0_wbio in OpenSSL
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Aug 1, 2023
Will be auto-detected in next curl release: curl/curl@dee310d curl/curl#11555
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
Present in OpenSSL 1.1.0 and BoringSSL. Missing from LibreSSL 3.8.0. Follow-up to f39472e While here, also fix `RAND_egd()` detection which was broken, likely all along. This feature is probably broken with CMake builds and also requires a sufficiently obsolete OpenSSL version, so this part of the update was not tested. Closes curl#11555
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Oct 19, 2023
Regression from dee310d #curl#11555 Reported-by: Casey Bodley Fixes curl#12160 Closes #xxxxx
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Oct 19, 2023
An orphan call to `CheckQuicSupportInOpenSSL()` remained after a recent update when checking QUIC for quiche. Restore this function and fixup the callers to use it. Regression from dee310d #curl#11555 Reported-by: Casey Bodley Fixes curl#12160 Closes #xxxxx
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Oct 19, 2023
An orphan call to `CheckQuicSupportInOpenSSL()` remained after a recent update when checking QUIC for quiche. Restore this function and fixup the callers to use it. Regression from dee310d #curl#11555 Reported-by: Casey Bodley <cbodley@redhat.com> Fixes curl#12160 Closes curl#12162
vszakats
added a commit
that referenced
this pull request
Oct 22, 2023
An orphan call to `CheckQuicSupportInOpenSSL()` remained after a recent update when checking QUIC for quiche. Move back QUIC detection to a function and fixup callers to use that. Also make sure that quiche gets QUIC from BoringSSL, because it doesn't support other forks at this time. Regression from dee310d #11555 Reported-by: Casey Bodley <cbodley@redhat.com> Fixes #12160 Closes #12162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Present in OpenSSL 1.1.0 and BoringSSL.
Missing from LibreSSL 3.8.0.
Follow-up to f39472e
While here, also fix
RAND_egd()detection which was broken, likely allalong. This feature is probably broken with CMake builds and also
requires a sufficiently obsolete OpenSSL version, so this part of the
update was not tested.
Closes #11555