cmake: cache more config and delete unused ones #11551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
force-pushed
the
cmake-windows-precache-more
branch
from
e25bea5
to
f8d9401
Compare
vszakats
force-pushed
the
cmake-windows-precache-more
branch
from
f8d9401
to
4f51020
Compare
It doesn't seem to be used since ecd29a2 (from 2002), but the header reference lived on and got copy-pasted to more protocols. References in libssh.c/libssh2.c seems were unused all along. They were guarded by `HAVE_UTSNAME_H`, which was not defined by either autotools or cmake. The header was detected by cmake, but used the different macro name: `HAVE_SYS_UTSNAME_H`, and also missed to include in `curl_config.h`.
vszakats
force-pushed
the
cmake-windows-precache-more
branch
from
4f51020
to
39801d7
Compare
vszakats
changed the title
vszakats
changed the title
vszakats
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
|
This test is failing 38.5% of the time already, so it is probably not related to this PR.
|
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
- cache more Windows config results for faster initialization. - delete unused config macros `HAVE_SYS_UTSNAME_H`, `HAVE_SSL_H`. - delete dead references to `sys/utsname.h`. Closes curl#11551
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cache more Windows config results for faster initialization.
delete unused config macros
HAVE_SYS_UTSNAME_H,HAVE_SSL_H.delete dead references to
sys/utsname.h.Closes #11551