Some work on the OS/400 port #11547
Closed
Some work on the OS/400 port #11547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monnerat
force-pushed
the
os400-cli
branch
2 times, most recently
from
d245aae
to
939f33d
Compare
monnerat
force-pushed
the
os400-cli
branch
2 times, most recently
from
2d19142
to
6b4b82e
Compare
|
Oops, #11650 made this merge conflict |
Yes, I was expecting it. Fixed now, together with some adaptations to latest commits. |
monnerat
force-pushed
the
os400-cli
branch
2 times, most recently
from
44aee43
to
dff2dbb
Compare
This is provided as a QADRT (ascii) program, a link to it in the IFS and a minimal CL command.
They can then easily be overriden in a script named "config400.override" that is not part of the distribution.
OS400 uses BSD 4.3 setsockopt() prototype by default: this does not define parameter as const, resulting in an error if actual parameter is const. Remove the const keyword from the actual parameter cast: this works in all conditions, even if the formal parameter uses it.
Also fix a non-compliant main prototype in disabled.c.
|
@bagder: are you planning to pull this before release? There is an OS400 build fix (followup to commit cfe85ca) in it. I would prefer not to backport it. |
|
@monnerat it is very helpful if you request a review from me or otherwise mention in a comment that the PR is ready for merge when it is, as it is hard for me to keep track. Then I could perhaps act a little sooner on PRs. I'll get to this one asap! |
Thanks! |
bagder
approved these changes
Aug 30, 2023
bagder
pushed a commit
that referenced
this pull request
Aug 30, 2023
They can then easily be overriden in a script named "config400.override" that is not part of the distribution. Closes #11547
bagder
pushed a commit
that referenced
this pull request
Aug 30, 2023
bagder
pushed a commit
that referenced
this pull request
Aug 30, 2023
OS400 uses BSD 4.3 setsockopt() prototype by default: this does not define parameter as const, resulting in an error if actual parameter is const. Remove the const keyword from the actual parameter cast: this works in all conditions, even if the formal parameter uses it. Closes #11547
bagder
pushed a commit
that referenced
this pull request
Aug 30, 2023
Also fix a non-compliant main prototype in disabled.c. Closes #11547
bagder
pushed a commit
that referenced
this pull request
Aug 30, 2023
|
Thanks! |
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
This is provided as a QADRT (ascii) program, a link to it in the IFS and a minimal CL command. Closes curl#11547
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
They can then easily be overriden in a script named "config400.override" that is not part of the distribution. Closes curl#11547
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
OS400 uses BSD 4.3 setsockopt() prototype by default: this does not define parameter as const, resulting in an error if actual parameter is const. Remove the const keyword from the actual parameter cast: this works in all conditions, even if the formal parameter uses it. Closes curl#11547
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
Also fix a non-compliant main prototype in disabled.c. Closes curl#11547
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important commit of this bunch implements the curl cli tool in the ILE environment.
This is an important step towards supporting the tests on OS/400.
There is also a libtests compilation error fix.
The OS/400 build parameters are now customized in a separate file.
Rest is minor fixes and specific doc update.
Compiles and runs (tested manually!).